From 307554c1cbf318a6065ebb6acad04a59ec42b1f5 Mon Sep 17 00:00:00 2001
From: Giuseppe Congiu <gcongiu@icl.utk.edu>
Date: Fri, 1 Dec 2023 16:42:58 +0100
Subject: [PATCH] ci: run tests with and without PAPI debug enabled

Tests should make sure real use cases work as expected. Some tests might
not working correctly if -O0 is used as optimization level in the
compiler. For example, the ROCm runtime submits a kernel of 4 waves if
the tests are built using -O0, which makes the tests fail.

Update the github test configuration matrix to include testing without
PAPI debug.
---
 .github/workflows/ci.sh    | 7 ++++---
 .github/workflows/main.yml | 9 ++++++---
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/ci.sh b/.github/workflows/ci.sh
index daaf5f125..38652db2b 100755
--- a/.github/workflows/ci.sh
+++ b/.github/workflows/ci.sh
@@ -1,7 +1,8 @@
 #!/bin/bash -e
 
 COMPONENT=$1
-COMPILER=$2
+DEBUG=$2
+COMPILER=$3
 
 [ -z "$COMPILER" ] && COMPILER=gcc@11
 
@@ -43,9 +44,9 @@ if [ "$COMPONENT" = "infiniband_umad" ]; then
 fi
 
 if [ "$COMPONENT" = "perf_event" ]; then
-  ./configure --with-debug=yes --enable-warnings
+  ./configure --with-debug=$DEBUG --enable-warnings
 else
-  ./configure --with-debug=yes --enable-warnings --with-components=$COMPONENT
+  ./configure --with-debug=$DEBUG --enable-warnings --with-components=$COMPONENT
 fi
 
 make -j4
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 94e5790e3..0f3b01f6d 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -14,35 +14,38 @@ jobs:
     strategy:
       matrix:
         component: [perf_event, lmsensors, io, net, powercap, appio, coretemp, stealtime]
+        debug: [yes, no]
       fail-fast: false
     runs-on: cpu_intel
     timeout-minutes: 60
     steps:
       - uses: actions/checkout@v3
       - name: Test
-        run: .github/workflows/ci.sh ${{matrix.component}}
+        run: .github/workflows/ci.sh ${{matrix.component}} ${{matrix.debug}}
   papi_component_nvidia:
     strategy:
       matrix:
         component: [cuda, nvml]
+        debug: [yes, no]
       fail-fast: false
     runs-on: gpu_nvidia
     timeout-minutes: 60
     steps:
       - uses: actions/checkout@v3
       - name: Test
-        run: .github/workflows/ci.sh ${{matrix.component}}
+        run: .github/workflows/ci.sh ${{matrix.component}} ${{matrix.debug}}
   papi_component_amd:
     strategy:
       matrix:
         component: [rocm, rocm_smi]
+        debug: [yes, no]
       fail-fast: false
     runs-on: gpu_amd
     timeout-minutes: 60
     steps:
       - uses: actions/checkout@v3
       - name: Test
-        run: .github/workflows/ci.sh ${{matrix.component}}
+        run: .github/workflows/ci.sh ${{matrix.component}} ${{matrix.debug}}
   papi_spack:
     runs-on: cpu
     timeout-minutes: 60