From 79f0c99ebdeb908e9f3605bc229b839f01bce850 Mon Sep 17 00:00:00 2001 From: Harald Pretl Date: Wed, 30 Oct 2024 13:03:39 +0100 Subject: [PATCH 1/8] Fixed linting warnings --- src/uart_rx.v | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/uart_rx.v b/src/uart_rx.v index c2935ae..fd097c5 100644 --- a/src/uart_rx.v +++ b/src/uart_rx.v @@ -31,7 +31,6 @@ module uart_rx #( reg [ 2:0] next_state; reg [ 31:0] cycle_cnt; reg [ 3:0] bit_cnt; - reg rx_reg; // FSM: next state latch always @(posedge clk or negedge rst_n) begin @@ -92,4 +91,4 @@ module uart_rx #( end endmodule -`endif \ No newline at end of file +`endif From f691d3a446f93774c318bf5d4986523fdda06c54 Mon Sep 17 00:00:00 2001 From: Harald Pretl Date: Wed, 30 Oct 2024 13:04:25 +0100 Subject: [PATCH 2/8] Fix lint warning --- src/uart_tx.v | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/uart_tx.v b/src/uart_tx.v index 49b5fa7..3b1c20a 100644 --- a/src/uart_tx.v +++ b/src/uart_tx.v @@ -104,4 +104,4 @@ module uart_tx #( end endmodule -`endif \ No newline at end of file +`endif From 39a416bf7a908ee79151047d3e31165297439651 Mon Sep 17 00:00:00 2001 From: Harald Pretl Date: Wed, 30 Oct 2024 13:08:32 +0100 Subject: [PATCH 3/8] Fixed linting warnings --- src/wb_uart.v | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/wb_uart.v b/src/wb_uart.v index aaa69be..067ff4e 100644 --- a/src/wb_uart.v +++ b/src/wb_uart.v @@ -18,7 +18,14 @@ module wb_uart( input wire rx ); - + /* verilator lint_off UNUSEDSIGNAL */ + wire [15:0] dummy1; + assign dummy1 = adr_i; + wire [31:8] dummy2; + assign dummy2 = dat_i[31:8]; + wire [3:0] dummy3; + assign dummy3 = sel_i; + /* verilator lint_on UNUSEDSIGNAL */ wire [7:0] dat_tmp; assign dat_o = {24'b0, dat_tmp}; @@ -27,7 +34,6 @@ module wb_uart( wire rx_start = stb_i & cyc_i & ~we_i & sel_i[0]; wire tx_ready; wire rx_ready; - reg working; localparam S_IDLE = 0; localparam S_WORKING_TX = 1; @@ -77,4 +83,4 @@ module wb_uart( .rx_pin(rx)); endmodule -`endif \ No newline at end of file +`endif From beb2200a132d21b62a2a522ed357c5ecd7e3fc10 Mon Sep 17 00:00:00 2001 From: Harald Pretl Date: Wed, 30 Oct 2024 13:10:08 +0100 Subject: [PATCH 4/8] Fix lint warning --- src/wb_spi.v | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/wb_spi.v b/src/wb_spi.v index 149cac3..5be5380 100644 --- a/src/wb_spi.v +++ b/src/wb_spi.v @@ -25,6 +25,13 @@ module wb_spi( output wire spi_data_o ); + /* verilator lint_off UNUSEDSIGNAL */ + wire [31:7] dummy1; + assign dummy1 = adr_i[31:7]; + wire [3:0] dummy2; + assign dummy2 = adr_i[3:0]; + /* verilator lint_on UNUSEDSIGNAL */ + localparam S_IDLE = 0; localparam S_SENDING = 1; @@ -95,4 +102,4 @@ module wb_spi( assign spi_data_o = (state == S_SENDING) ? cmd[31] : 1'b0; endmodule -`endif \ No newline at end of file +`endif From 9e363a57547e314644c2a97f815c3b827dc4cc02 Mon Sep 17 00:00:00 2001 From: Harald Pretl Date: Wed, 30 Oct 2024 13:11:26 +0100 Subject: [PATCH 5/8] Fixed lint warning --- src/wb_imem.v | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/wb_imem.v b/src/wb_imem.v index 3015fb6..5c04234 100644 --- a/src/wb_imem.v +++ b/src/wb_imem.v @@ -20,6 +20,15 @@ module wb_imem( output wire spi_data_o ); + /* verilator lint_off UNUSEDSIGNAL */ + wire [31:0] dummy1; + assign dummy1 = adr_i; + wire [31:0] dummy2; + assign dummy2 = dat_i[31:0]; + wire [3:0] dummy3; + assign dummy3 = sel_i; + /* verilator lint_on UNUSEDSIGNAL */ + localparam S_IDLE = 2'd0; localparam S_SENDING = 2'd1; localparam S_RECEIVING = 2'd2; @@ -74,4 +83,4 @@ module wb_imem( assign spi_data_o = (state == S_SENDING) ? cmd[31] : 1'b0; endmodule -`endif \ No newline at end of file +`endif From f79d4ec4069ffd99f9dfe6301aa52f0661ae50b5 Mon Sep 17 00:00:00 2001 From: Harald Pretl Date: Wed, 30 Oct 2024 13:25:23 +0100 Subject: [PATCH 6/8] Fix linting warnings --- src/wb_gpio.v | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/wb_gpio.v b/src/wb_gpio.v index 687c0a5..04cbe28 100644 --- a/src/wb_gpio.v +++ b/src/wb_gpio.v @@ -16,8 +16,17 @@ module wb_gpio( output wire [3:0] gpio_o ); + /* verilator lint_off UNUSEDSIGNAL */ + wire [31:0] dummy1; + assign dummy1 = adr_i; + wire [31:0] dummy2; + assign dummy2 = dat_i[31:0]; + wire [3:0] dummy3; + assign dummy3 = sel_i; + /* verilator lint_on UNUSEDSIGNAL */ + reg [3:0] data_o; - reg [3:0] data_i; + wire [3:0] data_i; assign gpio_o = data_o; assign data_i = gpio_i; @@ -40,4 +49,4 @@ module wb_gpio( end endmodule -`endif \ No newline at end of file +`endif From 13a74ab64d9906d82211b2b6ae5263a1c155498f Mon Sep 17 00:00:00 2001 From: FRoith Date: Wed, 30 Oct 2024 13:35:39 +0100 Subject: [PATCH 7/8] Fix unused assignments for gpio --- src/wb_gpio.v | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/wb_gpio.v b/src/wb_gpio.v index 04cbe28..96d3695 100644 --- a/src/wb_gpio.v +++ b/src/wb_gpio.v @@ -17,10 +17,10 @@ module wb_gpio( ); /* verilator lint_off UNUSEDSIGNAL */ - wire [31:0] dummy1; - assign dummy1 = adr_i; - wire [31:0] dummy2; - assign dummy2 = dat_i[31:0]; + wire [31:2] dummy1; + assign dummy1 = adr_i[31:2]; + wire [31:1] dummy2; + assign dummy2 = dat_i[31:1]; wire [3:0] dummy3; assign dummy3 = sel_i; /* verilator lint_on UNUSEDSIGNAL */ From da2b2decaa1a449f297f98cdbbf4c8a049d1bb56 Mon Sep 17 00:00:00 2001 From: FRoith Date: Wed, 30 Oct 2024 13:38:04 +0100 Subject: [PATCH 8/8] fix unused wb_imem signals --- src/wb_imem.v | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wb_imem.v b/src/wb_imem.v index 5c04234..d9f3de0 100644 --- a/src/wb_imem.v +++ b/src/wb_imem.v @@ -21,8 +21,8 @@ module wb_imem( ); /* verilator lint_off UNUSEDSIGNAL */ - wire [31:0] dummy1; - assign dummy1 = adr_i; + wire [31:24] dummy1; + assign dummy1 = adr_i[31:24]; wire [31:0] dummy2; assign dummy2 = dat_i[31:0]; wire [3:0] dummy3;