Natural Sort without interop #3196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophwille
added
the
dependencies
| [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1060:MovePInvokesToNativeMethodsClass")] | ||
| public sealed class NaturalStringComparer : IComparer<string> | ||
| public sealed class NativeNaturalStringComparer : IComparer<string> |
There was a problem hiding this comment.
Why do we keep the old one around?
There was a problem hiding this comment.
That is just for optionality reasons - eg if we ever wanted to compare for a bug report on sorting.
siegfriedpammer
approved these changes
Apr 26, 2024
mattsh247
pushed a commit
to mattsh247/ILSpy
that referenced
this pull request
Jul 30, 2024
* Use NaturalSort.Extension instead of Interop * Update to latest NaturalSort.Extensions and update 3rd party notices * Remove old interop implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using NaturalSort.Extensions 4.3 that was updated for Unicode as per tompazourek/NaturalSort.Extension#74
Benchmark https://github.com/christophwille/poc-oh/blob/main/src/NaturalSortBenchmark/README.md