Convert the C# sample projects to PackageReference format #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piksel
approved these changes
Nov 21, 2020
Member
piksel
left a comment
piksel
left a comment
There was a problem hiding this comment.
LGTM. Added suggestions for updating to the just released v1.3.1
samples/ICSharpCode.SharpZipLib.Samples/cs/Cmd_BZip2/Cmd_BZip2.csproj
Outdated
Show resolved
Hide resolved
samples/ICSharpCode.SharpZipLib.Samples/cs/Cmd_Checksum/Cmd_Checksum.csproj
Outdated
Show resolved
Hide resolved
samples/ICSharpCode.SharpZipLib.Samples/cs/Cmd_GZip/Cmd_GZip.csproj
Outdated
Show resolved
Hide resolved
samples/ICSharpCode.SharpZipLib.Samples/cs/Cmd_Tar/Cmd_Tar.csproj
Outdated
Show resolved
Hide resolved
samples/ICSharpCode.SharpZipLib.Samples/cs/Cmd_ZipInfo/Cmd_ZipInfo.csproj
Outdated
Show resolved
Hide resolved
samples/ICSharpCode.SharpZipLib.Samples/cs/FastZip/FastZip.csproj
Outdated
Show resolved
Hide resolved
samples/ICSharpCode.SharpZipLib.Samples/cs/unzipfile/unzipfile.csproj
Outdated
Show resolved
Hide resolved
samples/ICSharpCode.SharpZipLib.Samples/cs/viewzipfile/viewzipfile.csproj
Outdated
Show resolved
Hide resolved
Contributor
Author
|
It should also be possible to put the SharpZipLib package version and/or the PackageReference in a shared .props file (such that the version can be updated in once place rather than having to change every project file). Not sure if that's a good idea or not though. |
This was referenced Jul 25, 2025
This was referenced Aug 26, 2025
This was referenced Nov 10, 2025
This was referenced Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part one of the suggestion from #526 - convert the C# sample projects from packages.config to PackageReference format (and delete all the packages.config files)
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.