Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss the possibility of integrating whole-body dynamics into the robot interface of the simulation #203

Open
GiulioRomualdi opened this issue Dec 18, 2023 · 7 comments
Labels
domain-software Related to Software prj-ergocub Related to ErgoCub Project team-fix Related to Team Fix

Comments

@GiulioRomualdi
Copy link
Contributor

I am opening this issue to discuss the possibility of enabling the automatic execution of whole-body dynamics when the robot is dropped into Gazebo.

In our research at AMI, we utilize whole-body dynamics to calculate the estimated contact force. Currently, many team members manually run whole-body dynamics after placing the robot in Gazebo. Automating this process would simplify the simulation.

Furthermore, WBD running within the same YARP robot interface as the simulation would eliminate the need for a network wrapper to retrieve data from the simulated robot.

cc @traversaro @Nicogene

@GiulioRomualdi GiulioRomualdi added domain-software Related to Software prj-ergocub Related to ErgoCub Project team-fix Related to Team Fix labels Dec 18, 2023
@traversaro
Copy link
Member

Related issue: #35 .

@Nicogene
Copy link
Member

Nicogene commented Dec 18, 2023

Hi @GiulioRomualdi, do you mean making run wbd via the yarprobotinterface gazebo plugin?
This may be a problem for whom wants to use ergoCub model without having installed the whole-body-estimators repo, this is a similar discussion we had about putting the ros2 nws spawned by default

@GiulioRomualdi
Copy link
Contributor Author

Yes that's make sense you're right

@GiulioRomualdi
Copy link
Contributor Author

GiulioRomualdi commented Dec 20, 2023

One possibility is to verify whether the whole-body-estimator is installed in the system. If it is, the XML file can then include the device. Otherwise, this functionality can be enabled through CMake.

@traversaro
Copy link
Member

One possibility is to verify whether the whole-body-estimator is installed in the system. If it is, the XML file can then include the device. Otherwise, this functionality can be enabled through CMake.

To be honest, I would avoid that, as then downstream you need to handle both cases, and it may be quite easy to get the wrong file. As most users of ergocub are inside IIT, I would just understand if that is actually a problem for someone, and if not we just enable whole-body-estimator, what do you think?

@Nicogene
Copy link
Member

One possibility is to verify whether the whole-body-estimator is installed in the system. If it is, the XML file can then include the device. Otherwise, this functionality can be enabled through CMake.

To be honest, I would avoid that, as then downstream you need to handle both cases, and it may be quite easy to get the wrong file. As most users of ergocub are inside IIT, I would just understand if that is actually a problem for someone, and if not we just enable whole-body-estimator, what do you think?

I think that this is something that can be asked in the internal channel of ergoCub, if everyone agrees we can add it

@traversaro
Copy link
Member

We could use robotology/gazebo-yarp-plugins#672 to either permit to disable or to enable (depending on what we want the default to be) wbd. If the default on the robot is to have wbd on, I would keep it by default on also on the simulated robot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain-software Related to Software prj-ergocub Related to ErgoCub Project team-fix Related to Team Fix
Projects
None yet
Development

No branches or pull requests

3 participants