Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved user control over kernel and material coverage check #28117

Closed
jmeier opened this issue Jul 12, 2024 · 0 comments · Fixed by #28118
Closed

Improved user control over kernel and material coverage check #28117

jmeier opened this issue Jul 12, 2024 · 0 comments · Fixed by #28118
Assignees
Labels
C: Framework T: task An enhancement to the software.

Comments

@jmeier
Copy link
Contributor

jmeier commented Jul 12, 2024

Motivation

As per today, the kernel and material coverage check is "all" or "none":

[Problem]
  kernel_coverage_check = true|false
  material_coverage_check = true|false
[]

But fully switching off the coverage checks hinders debugging of Moose models. It would be nice to select subdomains to be checked or not to be checked.

Design

As discussed in #28092, it would be nice to have something like this:

kernel_coverage_check = true|on|false|off|skip_list|only_list     #(default is "true")
kernel_coverage_block_list = 'list of subdomains' 

and

material_coverage_check = true|on|false|off|skip_list|only_list     #(default is "true")
material_coverage_block_list = 'list of subdomains' 

With the additions options "skip_list" and "only_list" the user can exclude/include subdomains explicitly.

Impact

Only new functionality is added, but the type of kernel_coverage_check and material_coverage_check is to be changed to be an enum value. Due to fact, that the new enums also contain "true" and "false" (and "on" an "off") and the corresponding behaviour matches the behaviour today, the negative impact should be minimal.

@jmeier jmeier added the T: task An enhancement to the software. label Jul 12, 2024
jmeier added a commit to jmeier/moose that referenced this issue Jul 12, 2024
jmeier added a commit to jmeier/moose that referenced this issue Jul 12, 2024
jmeier added a commit to jmeier/moose that referenced this issue Jul 19, 2024
jmeier added a commit to jmeier/moose that referenced this issue Jul 19, 2024
jmeier added a commit to jmeier/moose that referenced this issue Jul 19, 2024
jmeier added a commit to jmeier/moose that referenced this issue Jul 21, 2024
jmeier added a commit to jmeier/moose that referenced this issue Jul 21, 2024
jmeier added a commit to jmeier/moose that referenced this issue Jul 21, 2024
N4hom pushed a commit to N4hom/moose that referenced this issue Jul 30, 2024
TheGreatCid pushed a commit to TheGreatCid/moose that referenced this issue Aug 1, 2024
TheGreatCid pushed a commit to TheGreatCid/moose that referenced this issue Aug 14, 2024
Leni-Yeo pushed a commit to Leni-Yeo/moose that referenced this issue Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework T: task An enhancement to the software.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants