Water tight sideset check #28816
Merged
Water tight sideset check #28816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 9, 2024 14:03
-Loops through each element, then each face -If face is external it needs to check if it has a sideset associate with it -If not it needs to return an accurate warning refs idaholab#25278
-Works for 2D and 3D meshes -Loops through all elements and checks each face/edge (3D/2D) -If face/edge is external it checks if it belongs to a sideset -If not it prints out info about the element it belongs to -At the end it prints out how many faces/edges are missing sidesets refs idaholab#25278
DanielYankura
requested review from
lindsayad,
roystgnr and
GiudGiud
as code owners
-Made comments more accurate -Changed for-loop for sides to be more readable
GiudGiud
reviewed
Oct 11, 2024
GiudGiud
reviewed
Oct 11, 2024
GiudGiud
reviewed
Oct 11, 2024
GiudGiud
reviewed
Oct 11, 2024
|
Job Documentation, step Docs: sync website on 5d61781 wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Coverage, step Generate coverage on 5d61781 wanted to post the following: Framework coverage
Modules coverageFluid properties
Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||||||||||||||||||||||||||||
-Formatting changes: removed {}
-used log_length_limit to limit output length
GiudGiud
approved these changes
Oct 12, 2024
|
test failures are not related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #25278
Reason
This makes it easier for users to find issues with their meshes.
Design
In the mesh block of an input file users can add check_for_watertight_sidesets = '...'. This check loops through all elements, finds the external faces/edges, and then checks if each one is part of a sideset. If not it prints our which elements have faces/edges missing sidesets. This only works for 2D and 3D meshes right now. For 2D it checks all external edges, and for 3D is checks all external faces.
Impact
Adds a watertight sideset check to Mesh Diagnostics