Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomSampler variable can't handle function. #573

Closed
10 tasks done
elementx54 opened this issue Feb 9, 2018 · 0 comments · Fixed by #598
Closed
10 tasks done

CustomSampler variable can't handle function. #573

elementx54 opened this issue Feb 9, 2018 · 0 comments · Fixed by #598
Labels
priority_normal task This tag should be used for any new capability, improvement or enanchment

Comments

@elementx54
Copy link
Contributor

elementx54 commented Feb 9, 2018


Issue Description

What did you expect to see happen?

I was using a <CustomSampler> to grab grid points for a model which had redundant variables. Usually I use a function which returns the same value as the other sampled variable, which has worked in the past with other samplers. Below is my input snippet example since I can't put up the actual input:

<CustomSampler name='ksam'>
  <Source class='DataObjects' type='PointSet'>actgrid</Source>
  <variable name='temp' />
  <variable name='same_temp'>
    <function>ret_temp</function>
  </variable>
</CustomSampler>
What did you see instead?

RAVEN told me that it could not find the "same_temp" variable in the source object, which is true. The source DataObject had time and temp in it. "same_temp" was suppose to be found from the function "ret_temp" which returned self.temp.

Do you have a suggested fix for the development team?

It seems like the CustomSampler does not have function variables since it doesn't require a distribution for the other variables.


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or improvement?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest stable branch? If yes, is there any issue tagged with stable (create if needed)?
  • 5. If the issue is being closed without a merge request, has an explanation of why it is being closed been provided?
@alfoa alfoa added priority_normal task This tag should be used for any new capability, improvement or enanchment labels May 17, 2018
alfoa added a commit that referenced this issue May 17, 2018
Closes #182
Closes #363
Closes #225
Closes #568 (obsolete with respect to the new DataObject)
Closes #56 (obsolete with respect to the new DataObject)
Closes #112
Closes #589
Closes #319
Closes #305
Closes #252
Closes #573
Closes #551
Closes #73
Closes #551 (overcome by establish_conda_env.sh script)
Closes #627
Closes #258
Closes #129
Closes #93
Closes #91
Closes #83
Closes #77
Closes #58
Closes #43
Closes #68

This PR addresses multiple Issues.
The following new features have been added:

    new Data object structure
    addition of DataSet class
    standardization of PostProcessors' outputs
    New ROMs (time-dependent)
    Possibility to handle vector input spaces (not just scalars)
    Degradation problems with printing solved
    EnsembleModel for Unstructured Input handling
    Reached 100% tests' documentation
    New Code interfaces (e.g. SCALE)
    Library update

THIS PULL REQUEST (AND THE NEW DEVEL) WILL BE THE RAVEN V 1.1 RELEASE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority_normal task This tag should be used for any new capability, improvement or enanchment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants