[WIP] Jimmy testing representativity based on changes in basic stat #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a _runLegacy for code still using dictionaries.
…esentativity-afterJosh-BasicStat
wangcj05
requested changes
Apr 6, 2022
There was a problem hiding this comment.
@Jimmy-INL I have a couple of comments for you to consider.
| #Internal Modules------------------------------------------------------------------------------------ | ||
| from .MetricInterface import MetricInterface | ||
| # from Metrics.metrics import MetricUtilities | ||
| from utils import InputData, InputTypes |
There was a problem hiding this comment.
use new ravenframework import strategy to import the modules
There was a problem hiding this comment.
@joshua-cogliati-inl, could you direct me to the new import strategy?
There was a problem hiding this comment.
Comment on lines
+107
to
+112
| senMeasurables = kwargs['senMeasurables'] | ||
| senFOMs = kwargs['senFOMs'] | ||
| covParameters = kwargs['covParameters'] | ||
| r = (senFOMs.T @ covParameters @ senMeasurables)/\ | ||
| np.sqrt(senFOMs.T @ covParameters @ senFOMs)/\ | ||
| np.sqrt(senMeasurables.T @ covParameters @ senMeasurables) |
There was a problem hiding this comment.
Why do you need to create a metric class to do this calculation? It seems to me this calculation is only specific to representativity. How can we use it for other applications? If not, I would suggest to move it the representativity PP.
tests/framework/PostProcessors/Validation/test_validation_gate_representativityLinModel.xml
Outdated
Show resolved
Hide resolved
tests/framework/PostProcessors/Validation/test_validation_gate_representativityLinModel.xml
Outdated
Show resolved
Hide resolved
tests/framework/PostProcessors/Validation/test_validation_gate_representativityLinModel.xml
Outdated
Show resolved
Hide resolved
tests/framework/PostProcessors/Validation/test_validation_gate_representativityLinModel.xml
Outdated
Show resolved
Hide resolved
tests/framework/PostProcessors/Validation/test_validation_gate_representativityLinModel.xml
Outdated
Show resolved
Hide resolved
|
I think this PR can be closed. @Jimmy-INL Please let me know if you need to reopen it. |
wangcj05
deleted the
Jimmy-testingRepresentativity-afterJosh-BasicStat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #1650 and #1546
What are the significant changes in functionality due to this change request?
This adds the representativity PP based on the validation gate
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.raven/tests/framework/user_guideandraven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.