Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve point position after adding warning overlay #600

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

keram
Copy link
Contributor

@keram keram commented Dec 20, 2022

Resolves part of:
idris-community/idris2-mode#36

"The cursor still jumps to the beginning of the line"

Before change

idris-warning-overlay-jump-before.mov

After change

idris-jump-warning-overlay-after-fix.mov

 - inline idris-get-line-region and remove cl-multiple-value-bind
 - remove extra goto-char
 - flatten body
Resolves part of:
idris-community/idris2-mode#36
> "The cursor still jumps to the beginning of the line"
@jfdm jfdm merged commit b7c50dd into idris-hackers:main Dec 21, 2022
@keram keram deleted the warning-overlay-jump branch December 28, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants