From 230f8a5d5ca5b34bc5bda67a2ba520d5cff7a4b6 Mon Sep 17 00:00:00 2001 From: Alexei Lozovsky Date: Wed, 19 May 2021 15:41:32 +0900 Subject: [PATCH] Pin Android NDK version to 21.4.7075529 GitHub Actions seems to experience some issues with detecting the right Android NDK to use. There all sorts of hacks with "side-by-side" installation and "ndk-bundle" which you can read about elsewhere. Resolve this predicament by pinning the NDK version we are using for building our native code, both BoringSSL and Themis JNI stuff. This means developers will have to install this specific version of NDK instead of using whatever they are using. But that's not a particular issue. NDK does not affect compatibility of apps either, unless Google really screws up and breaks something there. Not in our case though since we're not really using anything Android-specific in our code. [debug] run on CI [debug] disable stuff Revert "Pin Android NDK version to 21.4.7075529" This reverts commit 6767e614a9d7dabf74fa23aaf7b81a1a7af82eab. ANDROID_NDK_HOME ANDROID_NDK_HOME no 3.6.4 Revert "Revert "Pin Android NDK version to 21.4.7075529"" This reverts commit ae48ecd55b3045264ae8e223e579bca60675e5d6. what if? oh fuck you Revert "3.6.4" This reverts commit d369d2e259d29b48904df06f7a60a303413e5c07. Revert "no" This reverts commit 9d4774176b01b5308d246e6b0974f8643f0072c7. Revert "ANDROID_NDK_HOME" This reverts commit 36857d6c987fdef40e07e60c9ae86eb73225110e. Revert "ANDROID_NDK_HOME" This reverts commit f9b7ecb7d9f4d8ac3bf6d96eb5f8814d4c1d481d. Revert "Revert "Revert "Pin Android NDK version to 21.4.7075529""" This reverts commit 3122e246e9ae6423766a260bca1a718cebb473a0. asdasdas asdsd asdas chec it out asd do eet try to unfuck and build again oh fuck you too, actions comments Pin to macos-10.15 because fuck surpriises do list first try to make it faster what if I just remove these instead them just do this and disable this for a moment yep, seems to be working rename --- .github/workflows/test-java.yaml | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test-java.yaml b/.github/workflows/test-java.yaml index 4e45d4f5f..dc964deaa 100644 --- a/.github/workflows/test-java.yaml +++ b/.github/workflows/test-java.yaml @@ -20,6 +20,7 @@ on: - master - stable - release/* + - pin-android-ndk schedule: - cron: '0 6 * * *' # every day at 6:00 UTC @@ -30,6 +31,7 @@ jobs: unit-tests: name: Unit tests runs-on: ${{ matrix.os }} + if: false strategy: matrix: os: [ubuntu-latest, macos-latest] @@ -63,8 +65,15 @@ jobs: android-tests: name: Android emulator - runs-on: macos-latest + runs-on: macos-10.15 steps: + # This particular version of CMake confuses Gradle by not being semver. + # We're fine with 3.10.2 which is also installed. Keep an eye on the + # virtual environments though: + # https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md#android + - name: Nuke CMake 3.18.1-g262b901 + run: | + ~/Library/Android/sdk/tools/bin/sdkmanager --uninstall 'cmake;3.18.1' - name: Check out code uses: actions/checkout@v2 with: @@ -89,6 +98,7 @@ jobs: android-example: name: Example – AndroidThemis runs-on: ubuntu-latest + if: false steps: - name: Check out code uses: actions/checkout@v2 @@ -102,6 +112,7 @@ jobs: java-example: name: Example project – JavaThemis runs-on: ubuntu-latest + if: false steps: - name: Install system dependencies run: |