Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exists on path #15

Closed
wants to merge 1 commit into from
Closed

Conversation

ghasbon
Copy link

@ghasbon ghasbon commented Aug 6, 2024

I tried to compile on M1 macbook, there is an issue with the fs::exists method, it seems it was removed. So instead I propose to use path.exists() method.

@iliazeus
Copy link
Owner

iliazeus commented Aug 7, 2024

What compiler version are you using? Right now, this function only exists in the nightly versions, but it has been stabilized, and will soon make its way into more stable releases.

rust-lang/rust#83186

@iliazeus
Copy link
Owner

iliazeus commented Aug 7, 2024

I can probably just add ARM MacOS builds to the CI pipeline, so you don't have to build it yourself.

@iliazeus
Copy link
Owner

I've added the aarch64 macos builds to the ci matrix.

@ghasbon @cocciasecca can you please verify that the iso2god-aarch64-macos binary from this release works on your machines?

@cocciasecca
Copy link
Contributor

The link to the new release is not working

@iliazeus
Copy link
Owner

@cocciasecca
Copy link
Contributor

It works perfectly.👌

@iliazeus
Copy link
Owner

Okay, great!

fs:exists() is already in beta Rust, and soon will be in stable, so I'll just close this merge request for now.

The proper solution on my side is probably to add a rust-toolchain.toml, but I'll just be lazy and wait until the feature goes stable :)

@ghasbon
Copy link
Author

ghasbon commented Sep 12, 2024

A bit, late, thanks for the consideration

@iliazeus
Copy link
Owner

Rust 1.81 is out, and the current code now builds with stable Rust without issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants