Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separate testcrate #65

Closed
wants to merge 1 commit into from
Closed

Add separate testcrate #65

wants to merge 1 commit into from

Conversation

Nemo157
Copy link
Contributor

@Nemo157 Nemo157 commented Apr 11, 2018

Allows testing without inheriting features from the uom build, is tested
when running cargo test automatically be being a workspace member, so
will be tested on travis and appveyor. Includes all the examples from
uom so that these examples are tested as if they were part of a separate
application.

See previous discussion at #62. This is used for testing whether #61 is fixed.

@Nemo157
Add separate testcrate
f32078d 
Allows testing without inheriting features from the uom build, is tested
when running `cargo test` automatically be being a workspace member, so
will be tested on travis and appveyor. Includes all the examples from
uom so that these examples are tested as if they were part of a separate
application.
@iliekturtles
Copy link
Owner

Per the discussion in #62 I'd prefer to go the route of using compiletest-rs since it doesn't require switching over to a workspace. Although as I also mentioned in the other PR uom may eventually need to switch to a workspace if custom derive is used. Thoughts?

@Nemo157
Copy link
Contributor Author

Nemo157 commented Apr 12, 2018

Yeah compiletest-rs looks interesting and probably a better solution to this. I haven't had time to really look into it, if you want to close this feel free. And if you don't get round to implementing something based on compiletest-rs I might get time to look into it in the next few weeks.

@iliekturtles
Copy link
Owner

I'll leave the PR open for the moment, but will plan to cleanup the patch I posted the other day to use compiletest-rs.

@iliekturtles
Copy link
Owner

I started adding compiletest tests last week, but E0464 issues, even with the clean_rmeta work-around, seem very common so I'm less enthusiastic about this option and leaning back towards using a workspace.

@iliekturtles
Copy link
Owner

Decided to go with the separate test crate: d0efe67

@Nemo157 Nemo157 deleted the testcrate branch April 18, 2018 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nemo157 @iliekturtles