Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] Update Ember to 4.12 #1063

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Conversation

jrjohnson
Copy link
Member

Updated the docs, test-app, and add-on to Ember 4.12 with all blueprints.

Possibly breaking, drops support for node <16 and Ember < 4.4

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for ember-simple-charts ready!

Name Link
🔨 Latest commit 19f30f7
🔍 Latest deploy log https://app.netlify.com/sites/ember-simple-charts/deploys/650c6ad4f55d1c000804238e
😎 Deploy Preview https://deploy-preview-1063--ember-simple-charts.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jrjohnson jrjohnson marked this pull request as ready for review September 21, 2023 16:05
There is something up with testing and running this version. It's not in
our code and it's not a supported LTS anymore so let's just drop it from
official support. It will almost certainly still work fine, just not
testing against it anymore.
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stopfstedt stopfstedt merged commit 6c2ea80 into ilios:master Sep 21, 2023
13 checks passed
@jrjohnson jrjohnson deleted the update-ember-4.12 branch September 21, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants