-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #879
Update dependencies #879
Conversation
✔️ Deploy Preview for ember-simple-charts ready! 🔨 Explore the source changes: bd82a26 🔍 Inspect the deploy log: https://app.netlify.com/sites/ember-simple-charts/deploys/621541f74081e400074ea810 😎 Browse the preview: https://deploy-preview-879--ember-simple-charts.netlify.app/ |
this one actually works, turns out the esdoc plugin wasn't rendering component docs correctly.
github actions is bugged when using earlier versions of npm. see actions/setup-node ticket 214.
this was only needed if we're using lockfile v2, and we downgraded to v1, so enforcing this npm version is not neccessary anymore.
turns out netlify can be configured with npm8, so we can build/test with the upgraded versions after all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe drop the translations? Maybe not. That's my only comment.
instead, just set the page title to be ignored by the template linter.
fixes #878
this leaves the following package dependencies with pending updates