Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #879

Merged
merged 29 commits into from
Feb 22, 2022
Merged

Update dependencies #879

merged 29 commits into from
Feb 22, 2022

Conversation

stopfstedt
Copy link
Member

@stopfstedt stopfstedt commented Feb 16, 2022

fixes #878

this leaves the following package dependencies with pending updates

stefan@nichtsnutz: ~/dev/projects/ember-simple-charts on update-deps
$ npm outdated
Package       Current  Wanted  Latest  Location                   Depended by
ember-cli      3.28.5  3.28.5   4.1.1  node_modules/ember-cli     ember-simple-charts
ember-source   3.28.8  3.28.8   4.2.0  node_modules/ember-source  ember-simple-charts
stefan@nichtsnutz: ~/dev/projects/ember-simple-charts/docs on update-deps
$ npm outdated
Package                     Current  Wanted  Latest  Location                                 Depended by
ember-cli                    3.28.5  3.28.5   4.1.1  node_modules/ember-cli                   docs
ember-source                 3.28.8  3.28.8   4.2.0  node_modules/ember-source                docs

@netlify
Copy link

netlify bot commented Feb 16, 2022

✔️ Deploy Preview for ember-simple-charts ready!

🔨 Explore the source changes: bd82a26

🔍 Inspect the deploy log: https://app.netlify.com/sites/ember-simple-charts/deploys/621541f74081e400074ea810

😎 Browse the preview: https://deploy-preview-879--ember-simple-charts.netlify.app/

@stopfstedt stopfstedt marked this pull request as ready for review February 18, 2022 22:56
github actions is bugged when using earlier versions of npm.
see actions/setup-node ticket 214.
this was only needed if we're using lockfile v2, and we downgraded to
v1, so enforcing this npm version is not neccessary anymore.
@stopfstedt stopfstedt requested a review from jrjohnson February 22, 2022 17:04
turns out netlify can be configured with npm8, so we can build/test with
the upgraded versions after all.
Copy link
Member

@jrjohnson jrjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe drop the translations? Maybe not. That's my only comment.

docs/config/ember-intl.js Outdated Show resolved Hide resolved
docs/app/templates/application.hbs Outdated Show resolved Hide resolved
instead, just set the page title to be ignored by the template linter.
@stopfstedt stopfstedt requested a review from jrjohnson February 22, 2022 20:05
@jrjohnson jrjohnson merged commit 1d8a85c into ilios:master Feb 22, 2022
@stopfstedt stopfstedt deleted the update-deps branch February 22, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies
2 participants