Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unneeded .slice() calls on data in frontend root components #8085

Merged
merged 1 commit into from
Aug 23, 2024
Merged

remove unneeded .slice() calls on data in frontend root components #8085

merged 1 commit into from
Aug 23, 2024

Conversation

michaelchadwick
Copy link
Contributor

Refs ilios/ilios#5660

This change removes all the unneeded calls to .slice() in all the root frontend root components (not located in a components/** subdir.

stopfstedt
stopfstedt previously approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stopfstedt stopfstedt self-requested a review August 21, 2024 02:07
@stopfstedt
Copy link
Member

i'll give this another look-over tomorrow. after discovering that sort() does not work on these ember-data relationships, i suspect that other in-place operations like reverse() don't work either.

@stopfstedt stopfstedt dismissed their stale review August 21, 2024 02:10

i need to take a second look at this.

stopfstedt
stopfstedt previously approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stopfstedt stopfstedt force-pushed the remove-slice-from-root-components branch from 3631d54 to f2c873e Compare August 22, 2024 22:37
@michaelchadwick michaelchadwick force-pushed the remove-slice-from-root-components branch from f2c873e to 3631d54 Compare August 22, 2024 23:15
@dartajax dartajax merged commit aedaeda into ilios:master Aug 23, 2024
67 of 70 checks passed
@michaelchadwick michaelchadwick deleted the remove-slice-from-root-components branch September 13, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dartajax dartajax dartajax approved these changes

@stopfstedt stopfstedt stopfstedt left review comments

@jrjohnson jrjohnson Awaiting requested review from jrjohnson jrjohnson is a code owner

Assignees

@dartajax dartajax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelchadwick @stopfstedt @dartajax