Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect offset on new Admin->Users queries #8090

Merged

Conversation

michaelchadwick
Copy link
Contributor

Fixes ilios/ilios#5665

Start tracking current query and compare to previous queries so we can reset offset if it's a different search term.

@michaelchadwick michaelchadwick changed the title fix incorrect offset on new queries fix incorrect offset on new Admin->Users queries Aug 22, 2024
Copy link
Member

@jrjohnson jrjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid solution. ✅

@dartajax dartajax merged commit fcce430 into ilios:master Aug 24, 2024
43 of 45 checks passed
@michaelchadwick michaelchadwick deleted the frontend-5665-admin-users-offset-bugfix branch September 13, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

user administration: reset pagination in user list when search filter changes.
3 participants