Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add disabled flag #176

Merged
merged 2 commits into from
May 22, 2020
Merged

feat: add disabled flag #176

merged 2 commits into from
May 22, 2020

Conversation

thejoeejoee
Copy link
Contributor

@thejoeejoee thejoeejoee commented May 17, 2020 •
edited
Loading

@iliyaZelenko, is here anything else what I should add since origin PR is marked as help-wanted?

@thejoeejoee
feat: add disabled flag
e044b01 
feat: add disabled flag

feat: add disabled flag

lint typo

remove doubled prop

lint typo
@thejoeejoee thejoeejoee force-pushed the feat-prop-disabled branch from 0ebc26c to e044b01 Compare May 17, 2020 14:38
@thejoeejoee thejoeejoee marked this pull request as draft May 17, 2020 15:17
@iliyaZelenko
Copy link
Owner

@thejoeejoee hi, it looks good! Thanks for the work done, I'm glad you noticed that I added help-wanted label.

is here anything else what I should add

The only thing that comes to the head, but with which I'm not sure, is to somehow style the content through CSS, so that it is more clearly visible that the content is not editable. For example, just do cursor: not-allowed. Maybe you have some ideas.

@thejoeejoee thejoeejoee force-pushed the feat-prop-disabled branch from 906a2a3 to 910d0e7 Compare May 21, 2020 17:12
@thejoeejoee
Copy link
Contributor Author

thejoeejoee commented May 21, 2020 •
edited
Loading

@iliyaZelenko Well, I've added cursor: not-allowed for entire editor and also light gray overlay to the entire component -- colors are taken from Vuetify light theme.
obrazek

@thejoeejoee thejoeejoee marked this pull request as ready for review May 21, 2020 19:45
@iliyaZelenko
Copy link
Owner

Great work, I watched how it works by running the project and I like it! Also, I have no complaints about the code, everything is fine.

@iliyaZelenko iliyaZelenko linked an issue May 22, 2020 that may be closed by this pull request
[Feature Request] : prop disabled #98
Closed
@iliyaZelenko iliyaZelenko merged commit c79b4bd into iliyaZelenko:master May 22, 2020
iliyaZelenko pushed a commit that referenced this pull request May 22, 2020
@semantic-release-bot
chore(release): 2.20.0 [skip ci]
aedda3c 
# [2.20.0](v2.19.0...v2.20.0) (2020-05-22)

### Features

* add disabled flag ([#176](#176)) ([c79b4bd](c79b4bd)), closes [#102](#102)
@iliyaZelenko
Copy link
Owner

🎉 This PR is included in version 2.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] : prop disabled
2 participants
@thejoeejoee @iliyaZelenko