Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(i18n) useless warning about unsupported current language #174

Merged
merged 1 commit into from
May 16, 2020
Merged

fix(i18n) useless warning about unsupported current language #174

merged 1 commit into from
May 16, 2020

Conversation

thejoeejoee
Copy link
Contributor

In warning about unsupported language is current language rewritten to default and after that is message logged.

Vuetify({locale: {current: 'XX'}})

now leads to:

tiptap-vuetify: The current language "en" is not yet available.
Using language "en" by default. Contribution to github is welcome.

but it should be:

tiptap-vuetify: The current language "XX" is not yet available.
Using language "en" by default. Contribution to github is welcome.

@iliyaZelenko iliyaZelenko merged commit ad551c1 into iliyaZelenko:master May 16, 2020
@iliyaZelenko
Copy link
Owner

Stupid mistake. Thanks, @thejoeejoee.

iliyaZelenko pushed a commit that referenced this pull request May 16, 2020
@semantic-release-bot
chore(release): 2.18.0 [skip ci]
34d67c2 
# [2.18.0](v2.17.0...v2.18.0) (2020-05-16)

### Bug Fixes

* **translation:** useless warning about unsupported current language ([#174](#174)) ([ad551c1](ad551c1))

### Features

* **i18n:** cs translation ([#173](#173)) ([2cf77ff](2cf77ff))
@iliyaZelenko
Copy link
Owner

🎉 This PR is included in version 2.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thejoeejoee @iliyaZelenko