Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large tokens make the UI way out of position #35

Closed
Zamrod opened this issue Aug 11, 2022 · 8 comments
Closed

Large tokens make the UI way out of position #35

Zamrod opened this issue Aug 11, 2022 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@Zamrod
Copy link

Zamrod commented Aug 11, 2022

While experimenting with extremely large tokens for Spelljamming ships, the scaler causes the HUD to be way out of position and most of it to be off screen entirely:

image

@Zamrod
Copy link
Author

Zamrod commented Aug 11, 2022

That is the size I would like the HUD to be, but it is just in the wrong spot

@Zamrod
Copy link
Author

Zamrod commented Aug 11, 2022

Here's a better picture of where the UI ends up
image

@illandril
Copy link
Owner

Can you provide me with the specific settings you are using for both the token (specifically the "Appearance" tab) and for the Token Hud Scaler module? (screenshots of those two settings windows are fine)

Also, please answer these questions...

Foundry Versions

  • Version of this module:
  • Foundry Version:
  • System Name and Version:
  • Browser Name and Version:

What other modules did you have active when experiencing this issue (include both names and versions)?
Tidy UI Game Settings (NOT Illandril's Tidy Module Settings) provides an Export option that makes getting this list easy.

@illandril illandril self-assigned this Aug 11, 2022
@illandril illandril added the needs more info The issue needs more information to be able to recreate or to know what changes would be preferred label Aug 11, 2022
@Zamrod
Copy link
Author

Zamrod commented Aug 11, 2022

Can you provide me with the specific settings you are using for both the token (specifically the "Appearance" tab) and for the Token Hud Scaler module? (screenshots of those two settings windows are fine)

image

image

Also, please answer these questions...

Foundry Versions

  • Version of this module:

image

  • Foundry Version:
  • System Name and Version:

image

  • Browser Name and Version:

Tried in both Chrome (Version 104.0.5112.81 (Official Build) (64-bit)) and Edge (Version 104.0.1293.47 (Official build) (64-bit))

What other modules did you have active when experiencing this issue (include both names and versions)? Tidy UI Game Settings (NOT Illandril's Tidy Module Settings) provides an Export option that makes getting this list easy.

I took the screenshot with other modules enabled but I disabled them all and attempted it again with the same effect. So other modules are not affecting the behavior.

@illandril
Copy link
Owner

I still want to know what other modules you were using that were changing what ends up in the HUD, to make sure any change I make doesn't break those modules.

The way the HUD works is there are three columns, with the middle column taking up the same width as the token.
The middle column is split into three rows, with the middle row taking up the same height as the token.
This layout of the HUD and this "Token Size" spacing are all part of Foundry itself.

You are experiencing two separate issues...

  1. The HUD isn't centered on the token (a bug in my HUD position adjustment logic in some scenarios)
  2. The HUD spacing being based on the token size isn't natural or desirable when the HUD doesn't scale based on the scale of the token (for smaller tokens, this strange spacing isn't a big deal, because it's still reasonably close... but as the token gets larger, that difference in spacing becomes more and more obvious)

Fixing issue 1 should be fairly trivial, but fixing just that would actually make things worse for you (because the first resource bar, which you're using for health, would also be really far from the token... though the second resource bar, which would currently off the screen for you if you had it on, would be close enough to actually be visible).
Fixing issue 2 will be trickier because lots of other modules mess with the contents of the HUD. If I change how big the HUD is relative to the token, that could break those other modules if any of them were positioning content based on the default HUD sizing logic.

@Zamrod
Copy link
Author

Zamrod commented Aug 11, 2022

moduleList.txt
Here's my module list renamed from .json to .txt

I think most of the UI that was added was from:
Show Art
Drag Ruler
DF's Quality of Life
Light's HUD+ATE
Argon Combat HUD

Though not listed there that I sometimes use is:
Token Variant Art

@illandril illandril added bug Something isn't working and removed needs more info The issue needs more information to be able to recreate or to know what changes would be preferred labels Aug 11, 2022
@illandril
Copy link
Owner

Thanks. I might have enough time to work on a fix this weekend (but no promises).

@illandril
Copy link
Owner

Note: This issue is fixed in the version of Illandril's Token HUD Scaler that supports v10 of FoundryVTT.
I recommend waiting until v10 is released, and all the modules you use have been updated to support v10 before updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants