(cqfn#215) LCOM4 static fields are now called by FQN (rounding error …

…as a param)
ilyakharlamov · Jan 25, 2019 · 4ae3d32 · 4ae3d32
1 parent 1712cc7
commit 4ae3d32
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/test/java/org/jpeek/metrics/Lcom4Test.java b/src/test/java/org/jpeek/metrics/Lcom4Test.java
@@ -39,6 +39,7 @@
  * @since 0.28
  * @checkstyle JavadocMethodCheck (500 lines)
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
+ * @checkstyle MagicNumberCheck (500 lines)
  */
 public final class Lcom4Test {
 
@@ -100,7 +101,7 @@ public void methodMethodCalls() throws Exception {
             ).size()
         );
         report.assertVariable(Lcom4Test.ATTRIBUTES, 1);
-        report.assertValue(1.0f, 0.001);
+        report.assertValue(1.0f, 0.001f);
     }
 
     /**
@@ -126,7 +127,7 @@ public void oneCommonAttribute() throws Exception {
         );
         report.assertVariable(Lcom4Test.ATTRIBUTES, 1);
         report.assertVariable(Lcom4Test.PAIRS, 1);
-        report.assertValue(1.0f, 0.001d);
+        report.assertValue(1.0f, 0.001f);
     }
 
     /**
@@ -146,7 +147,7 @@ public void notCommonAttributes() throws Exception {
         );
         report.assertVariable(Lcom4Test.ATTRIBUTES, 2);
         report.assertVariable(Lcom4Test.PAIRS, 0);
-        report.assertValue(2.0f, 0.001);
+        report.assertValue(2.0f, 0.001f);
     }
 
     /**
@@ -162,6 +163,6 @@ public void notCommonAttributesWithAllArgsConstructor() throws Exception {
         );
         report.assertVariable(Lcom4Test.ATTRIBUTES, 2);
         report.assertVariable(Lcom4Test.PAIRS, 0);
-        report.assertValue(2.0f);
+        report.assertValue(2.0f, 0.001f);
     }
 }
diff --git a/src/test/java/org/jpeek/metrics/MetricBase.java b/src/test/java/org/jpeek/metrics/MetricBase.java
@@ -136,7 +136,7 @@ public void assertVariable(final String variable,
          * @param error Rounding tolerance since the metric is float number
          * @throws Exception String format exception
          */
-        public void assertValue(final double value, double error) {
+        public void assertValue(final double value, final double error) {
             new Assertion<>(
                 "The metric value is not calculated properly",
                 () -> Double.parseDouble(