Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(server): asset core #6985

Merged
merged 1 commit into from
Feb 8, 2024
Merged

refactor(server): asset core #6985

merged 1 commit into from
Feb 8, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Feb 8, 2024

  • Move the two asset core methods into the asset service (the only place they are used).
  • Remove obsolete/unused asset repository v1 methods

@jrasm91 jrasm91 changed the title refactor: asset core refactor(server): asset core Feb 8, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8fcc1c8
Status: ✅  Deploy successful!
Preview URL: https://56860edb.immich.pages.dev
Branch Preview URL: https://refactor-asset-core.immich.pages.dev

View logs

danieldietzler
danieldietzler approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing api-v1 stuff; always nice! :)

@jrasm91 jrasm91 merged commit bd1fa93 into main Feb 8, 2024
26 checks passed
@jrasm91 jrasm91 deleted the refactor/asset-core branch February 8, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler danieldietzler approved these changes

Assignees
No one assigned
Labels
changelog:skip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrasm91 @danieldietzler