Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): lazy load photo sphere viewer #7057

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

benmccann
Copy link
Contributor

Are there any panoramas in the demo instance? I didn't see a way to search for panoramas, so wasn't sure how to find one to test and check that I didn't break anything.

Before:

.svelte-kit/output/client/_app/immutable/chunks/asset-viewer.bSlvLiFG.js               1,581.26 kB │ gzip: 433.21 kB

After:

.svelte-kit/output/client/_app/immutable/chunks/photo-sphere-viewer-adapter.ctx2RvS1.js     566.44 kB │ gzip: 148.17 kB
.svelte-kit/output/client/_app/immutable/chunks/asset-viewer.9FWEg5V5.js                  1,011.00 kB │ gzip: 283.47 kB

@benmccann benmccann changed the title feat: lazy load photo sphere viewer feat(web): lazy load photo sphere viewer Feb 12, 2024
Copy link
Contributor

@mertalev mertalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a huge difference. Nicely done!

web/src/lib/components/asset-viewer/panorama-viewer.svelte Outdated Show resolved Hide resolved
@alextran1502 alextran1502 merged commit b43cadc into immich-app:main Feb 12, 2024
23 checks passed
@benmccann benmccann deleted the lazy-load-panoramas branch February 12, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants