Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web) open api client #7103

Merged
merged 2 commits into from
Feb 14, 2024
Merged

refactor(web) open api client #7103

merged 2 commits into from
Feb 14, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Feb 13, 2024

Continuation of #7097.

The only usages left are:

  • Enums
  • Requests that use response type blob
  • Requests that use progress event
  • Some types (identical) are imported from the axios package still I think.

image

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0242a7e
Status: ✅  Deploy successful!
Preview URL: https://875a4182.immich.pages.dev
Branch Preview URL: https://refactor-open-api-client.immich.pages.dev

View logs

return names[jobName];
};

let _key: string | undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now, but having a single global key wouldn't work in the case that we had a cloud version of immich serving multiple users and doing ssr. It's not a change from the current code and not a blocker, but I thought I'd mention it anyway. Could potentially be worth a TODO. The typical way to avoid such a situation is with context: sveltejs/kit#4339 (comment)

@jrasm91 jrasm91 merged commit d8631a0 into main Feb 14, 2024
26 checks passed
@jrasm91 jrasm91 deleted the refactor/open-api-client branch February 14, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants