fix(mobile): Fixes bottom exif info sheet modal drag controls #7165

martyfuhry · 2024-02-17T15:45:57Z

Tested both AdvancedBottomSheet and ExifBottomSheet
Uses the drag widget at the top to close the modal now
You can also drag anywhere on the modal to slide down
Except when the modal takes up the whole vertical view, then you need to use the drag widget at the top, but at least it isn't completely broken
Fixed an issue with the two column layout throwing rendering errors and displaying grey boxes

In the future, we can do something better with this, especially for the case when the full view is expanded.

…odal-draggable

cloudflare-workers-and-pages · 2024-02-18T03:51:39Z

Deploying with Cloudflare Pages

Latest commit:	`1dccd48`
Status:	✅ Deploy successful!
Preview URL:	https://4210b3dd.immich.pages.dev
Branch Preview URL:	https://fix-bottom-modal-draggable.immich.pages.dev

martyfuhry added 3 commits February 16, 2024 20:28

WIPip

7af516e

Fixed show modal bottom sheet to use drag handle

f28aecd

Fixes advanced bottom sheet scrolling

60ad318

martyfuhry added the 📱mobile label Feb 17, 2024

martyfuhry requested a review from shenlong-tanwen February 17, 2024 15:45

martyfuhry self-assigned this Feb 17, 2024

Merge branch 'main' of github.com:immich-app/immich into fix/bottom-m…

1dccd48

…odal-draggable

alextran1502 approved these changes Feb 18, 2024

View reviewed changes

alextran1502 merged commit 88214a4 into main Feb 18, 2024
25 checks passed

alextran1502 deleted the fix/bottom-modal-draggable branch February 18, 2024 04:03