Fix 500 errors on 404 routes #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Reply and Request decorators we need to check for the presence of the `metrics` object because in 404 errors it is not configured by the `onRoute` hook. Fixes #134
antoniomuso
requested changes
Mar 7, 2022
|
Let me know when you're done because somehow it still say there are changes to be addressed 👍 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Proposed changes
Perform a check on the presence of the
metricsobject in request and reply decorators to avoid runtime errors on404routes that haven't that object attached to their instance.Closes #134
⚙️ Types of changes
What types of changes does your code introduce? Put an
xin the boxes that apply