[import/order] Fix alphabetize bug with newlines-between

[AamuLumi]

Hello!

I tested the new alphabetize rule, and when used with newlines-between: "always", the plugin mark as invalid any lines which have not newline around.

For example :

import Constants from '@constants';
import Logger from '@server/tools/logger';

These lines are OK with this plugin configuration (1) :

'import/order': [
	'error',
	{
		groups: [['builtin', 'external'], 'internal', 'parent', 'sibling'],
		'newlines-between': 'always',
	},
],

but are invalid with this plugin configuration (2) :

'import/order': [
	'error',
	{
		alphabetize: { order: 'asc' },
		groups: [['builtin', 'external'], 'internal', 'parent', 'sibling'],
		'newlines-between': 'always',
	},
],

And the configuration (2) mark these lines as valid :

import Constants from '@constants';

import Logger from '@server/tools/logger';

I checked the alphabetize PR, and I saw this comment which is exactly the bug I have.
The next comment gives a solution to the problem.

So I just implemented the solution, and I also add the associated test.

Fixes #1561.

[coveralls]

Coverage increased (+0.06%) to 96.325% when pulling 9a3bafc on AamuLumi:master into 977da57 on benmosher:master.

[coveralls]

Coverage decreased (-0.2%) to 96.127% when pulling 614e55f on AamuLumi:master into 2d669b1 on benmosher:master.

[idpaterson]

Linking to #1561 in case anyone else is working on a PR for the same issue.

[ljharb]

Thanks!

[caseywebdev]

Any chance we can get a version 2.19.2 with this in it? I love the new alphabetize option but I also want the newlines-between option 😬

[caseywebdev]

@ljharb what do you think about cutting a 2.19.2 with this bugfix?

[ljharb]

It remains on my list of things to do; there's still something i'm the middle of fixing on this repo first.

[caseywebdev]

Sounds good, thanks

[ljharb]

v2.20.0 is released.