New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BF: Refine argument options for make_block_pulse #151

Merged

btasdelen merged 2 commits into imr-framework:dev from wtclarke:bf/make_block_pulse_args

Nov 17, 2023

Contributor

wtclarke commented Nov 14, 2023

Addresses #149.

Refines argument logic in make_block_pulse
Refines documentation in make_block_pulse
Adds tests for make_block_pulse (test_make_block_pulse.py)
Adds markers for tests to exclude the original sequence comparisons whilst matlab generated sequences not committed.

wtclarke added 2 commits

November 14, 2023 22:00


          Redo make_block_pulse argument logic, update doc, add test.

c2ea8d9


          Add markers to original sequence comparison tests, don;t run with ci …

eed901c

…until fixed. Modify sigpy tests to not have graphical output.

This was referenced Nov 14, 2023

Arguments of make_block_pulse are highly confusing #149

Closed

unused variable #136

Closed

btasdelen merged commit f20884f into imr-framework:dev

4 checks passed

schuenke mentioned this pull request

Release 1.4.2 #177

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet