Proposed changes for main verification attestor PR #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kris Coleman <kriscodeman@gmail.com>
Co-authored-by: Brandon Hunter <brandon_hunter-wm@discovery.com> Signed-off-by: Tom Meadows <tom@tmlabs.co.uk>
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
Merged
jkjell
force-pushed
the
feat/verification-attestation
branch
from
6fc599a to
1bd15fa
Compare
ChaosInTheCRD
commented
May 2, 2024
ChaosInTheCRD
commented
May 2, 2024
There was a problem hiding this comment.
Not sure why this is showing as a completely new file?
jkjell
force-pushed
the
feat/verification-attestation
branch
from
1bd15fa to
d33965f
Compare
…ttestor Signed-off-by: John Kjell <john@testifysec.com>
jkjell
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the implementations of the proposals made in the verification attestor PR, mainly to tidy things up a bit and ensure a good experience in https://github.com/in-toto/witness.
@mikhailswift feel free to accept / reject these proposals as you see fit 😄.