Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codespell: action, config + fixes #321

Merged
merged 9 commits into from
May 1, 2023

Conversation

yarikoptic
Copy link
Member

No description provided.

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic
Copy link
Member Author

@dbkeator I pushed commit also adding simplejson - so may be it would fix the tests. please approve my workflow or better even add me to "legit" contributors to not wait next time(s)

They have an interesting approach of Brownout schedule so it fails to import
more and more often as time goes and soon will always fail. See
https://pypi.org/project/sklearn/
I think it is tests artifact and was committed by mistake.
Ideally tests should be fixed to not write in the tree and use tempdir
@yarikoptic
Copy link
Member Author

ok, we got it all green - let's proceed with this

@yarikoptic yarikoptic merged commit b251ce4 into incf-nidash:master May 1, 2023
@github-actions
Copy link

🚀 PR was released in v4.0.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant