Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up install requirements #347

Merged
merged 1 commit into from
May 3, 2023
Merged

Clean up install requirements #347

merged 1 commit into from
May 3, 2023

Conversation

jwodder
Copy link
Collaborator

@jwodder jwodder commented May 3, 2023

Some of the packages listed as requirements were not actually in use, and there were some other packages used by pynidm that weren't listed.

Specifically:

  • duecredit was unused
  • graphviz (the Python project, not to be confused with actual Graphviz) was unused
  • orthauth was unused
  • pydotplus was unused
  • python-dateutil was used but unlisted; the code only worked because it was installed by another dependency
  • rdflib-jsonld has been subsumed into rdflib
  • scipy was used but unlisted; the code only worked because it was installed by another dependency
  • matplotlib and seaborn were unlisted, not installed by anything, and only used by a few files in nidm/experiment/tools/, none of which are entry points for the project; I decided to just list them as extras.

@jwodder jwodder added cleanup dependencies Update one or more dependencies version labels May 3, 2023
@yarikoptic
Copy link
Member

  • duecredit was unused

it might be unused directly, but having it installed guarantees that iff users run with DUECREDIT_ENABLED, then they would get citations. But indeed we better re-add it with corresponding reference (https://f1000research.com/articles/11-228 ? or there is a JOSS paper on "The Neuroimaging Data Model (NIDM) Linear Regression Tool" contained in here).

@yarikoptic
Copy link
Member

ok, let's proceed , thank you for combing them all up

@yarikoptic yarikoptic merged commit 3ce9526 into master May 3, 2023
@yarikoptic yarikoptic deleted the requirements branch May 3, 2023 19:38
@github-actions
Copy link

🚀 PR was released in v4.0.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup dependencies Update one or more dependencies version released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants