Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Docker-related files #351

Merged
merged 2 commits into from
May 4, 2023
Merged

Clean up Docker-related files #351

merged 2 commits into from
May 4, 2023

Conversation

jwodder
Copy link
Collaborator

@jwodder jwodder commented May 4, 2023

Part of #325.

@jwodder jwodder added the internal Changes only affect the internal API label May 4, 2023
@jwodder jwodder mentioned this pull request May 4, 2023
35 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #351 (ebf5379) into master (a4c1ba2) will increase coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
+ Coverage   33.63%   33.64%   +0.01%     
==========================================
  Files          50       50              
  Lines        7050     7047       -3     
  Branches     1781     1685      -96     
==========================================
  Hits         2371     2371              
- Misses       4500     4506       +6     
+ Partials      179      170       -9     

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jwodder jwodder added the cleanup label May 4, 2023
blazegraph:
build:
context: .
dockerfile: Dockerfile-blazegraph
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that may be someone forgot to commit that Docker-blazegraph and in general the idea to have it since IIRC blazegraph is used by the project for graphdb. May be @albertcrowley could clarify?

@yarikoptic
Copy link
Member

ok, for now let's proceed, and if anything - we can return needed pieces.

@yarikoptic yarikoptic merged commit ab539e5 into master May 4, 2023
@yarikoptic yarikoptic deleted the cleanup-docker branch May 4, 2023 21:25
@github-actions
Copy link

🚀 PR was released in v4.0.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup internal Changes only affect the internal API released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants