Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uses of urllib.request with requests #359

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

jwodder
Copy link
Collaborator

@jwodder jwodder commented May 4, 2023

Part of #325.

@jwodder jwodder added the internal Changes only affect the internal API label May 4, 2023
@jwodder jwodder mentioned this pull request May 4, 2023
35 tasks
@jwodder jwodder added the cleanup label May 4, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #359 (c3fe16c) into master (a4c1ba2) will increase coverage by 0.05%.
The diff coverage is 55.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
+ Coverage   33.63%   33.68%   +0.05%     
==========================================
  Files          50       51       +1     
  Lines        7050     7062      +12     
  Branches     1781     1784       +3     
==========================================
+ Hits         2371     2379       +8     
- Misses       4500     4504       +4     
  Partials      179      179              
Impacted Files Coverage Δ
src/nidm/experiment/Utils.py 27.26% <0.00%> (-0.10%) ⬇️
src/nidm/experiment/tools/nidm2bids.py 0.00% <0.00%> (ø)
src/nidm/experiment/CDE.py 75.00% <100.00%> (ø)
src/nidm/experiment/Query.py 71.89% <100.00%> (ø)
src/nidm/util.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yarikoptic
Copy link
Member

requests are already used, so I guess it does make sense to harmonize all http interactions through it. FWIW here is usage points:

src/nidm/experiment/Query.py:import requests
src/nidm/experiment/Query.py:            r2 = requests.post(
src/nidm/experiment/Query.py:            requests.post(
src/nidm/experiment/Utils.py:import requests
src/nidm/experiment/Utils.py:    response = requests.post(

Just need a conflict resolved first

@jwodder
Copy link
Collaborator Author

jwodder commented May 4, 2023

@yarikoptic Conflict resolved.

@yarikoptic yarikoptic merged commit d043c96 into master May 4, 2023
@yarikoptic yarikoptic deleted the no-urllib branch May 4, 2023 21:22
@github-actions
Copy link

🚀 PR was released in v4.0.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup internal Changes only affect the internal API released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants