Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove practically-unused joblib #360

Merged
merged 1 commit into from
May 4, 2023
Merged

Remove practically-unused joblib #360

merged 1 commit into from
May 4, 2023

Conversation

jwodder
Copy link
Collaborator

@jwodder jwodder commented May 4, 2023

joblib.Memory was imported & instantiated in a few places, but nothing was done with it.

@jwodder jwodder added cleanup dependencies Update one or more dependencies version labels May 4, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #360 (599410d) into master (a4c1ba2) will decrease coverage by 0.16%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
- Coverage   33.63%   33.48%   -0.16%     
==========================================
  Files          50       50              
  Lines        7050     7040      -10     
  Branches     1781     1781              
==========================================
- Hits         2371     2357      -14     
- Misses       4500     4503       +3     
- Partials      179      180       +1     
Impacted Files Coverage Δ
src/nidm/experiment/Query.py 71.73% <ø> (-0.16%) ⬇️
src/nidm/experiment/tools/rest.py 70.24% <ø> (-0.18%) ⬇️
src/nidm/experiment/tools/rest_statistics.py 17.64% <ø> (-8.67%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yarikoptic
Copy link
Member

seems LGTM, indeed those memory specs were added but not used even when added. probably copy pasted code from somewhere or used temporarily while debugging or smth like that. If actually to be come used -- should be easy to introduce

@yarikoptic yarikoptic merged commit cf788d1 into master May 4, 2023
@yarikoptic yarikoptic deleted the no-joblib branch May 4, 2023 17:54
@github-actions
Copy link

🚀 PR was released in v4.0.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup dependencies Update one or more dependencies version released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants