Open all text files with UTF-8 encoding #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #373 +/- ##
==========================================
+ Coverage 33.59% 33.64% +0.04%
==========================================
Files 51 51
Lines 7030 7030
Branches 1784 1784
==========================================
+ Hits 2362 2365 +3
+ Misses 4488 4485 -3
Partials 180 180
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yarikoptic
reviewed
May 5, 2023
| @@ -639,7 +639,7 @@ def cluster_number(): | |||
| # ask for help: how does one do a dendrogram, also without graphing? | |||
|
|
|||
| if o is not None: | |||
| f = open(o, "a") | |||
| f = open(o, "a", encoding="utf-8", encoding="utf-8") | |||
There was a problem hiding this comment.
one too many ;)
Suggested change
| f = open(o, "a", encoding="utf-8", encoding="utf-8") | |
| f = open(o, "a", encoding="utf-8") |
|
well, some of those files should not even be utf8 but AFAIK should be ascii... but I guess it would generally be more robust etc to just generally assume UTF-8 these days. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
open()without an explicit encoding uses the OS encoding, which is not always sensible. See PEP 597 et alii.