Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor printing the same text to both stdout and a file #376

Merged
merged 2 commits into from
May 30, 2023

Conversation

jwodder
Copy link
Collaborator

@jwodder jwodder commented May 30, 2023

@yarikoptic Here's your release PR.

@jwodder jwodder added cleanup release Create a release when this pr is merged internal Changes only affect the internal API labels May 30, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #376 (fbc0330) into master (24168ba) will increase coverage by 0.56%.
The diff coverage is 32.73%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
+ Coverage   33.87%   34.43%   +0.56%     
==========================================
  Files          51       52       +1     
  Lines        6947     6816     -131     
  Branches     1746     1672      -74     
==========================================
- Hits         2353     2347       -6     
+ Misses       4424     4302     -122     
+ Partials      170      167       -3     
Impacted Files Coverage Δ
...nidm/experiment/tools/nidm_affinity_propagation.py 0.00% <0.00%> (ø)
.../experiment/tools/nidm_agglomerative_clustering.py 0.00% <0.00%> (ø)
src/nidm/experiment/tools/nidm_gmm.py 0.00% <0.00%> (ø)
src/nidm/experiment/tools/nidm_kmeans.py 0.00% <0.00%> (ø)
src/nidm/experiment/tools/nidm_linreg.py 63.52% <53.03%> (+4.98%) ⬆️
src/nidm/experiment/tools/utils.py 80.00% <80.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yarikoptic
Copy link
Member

Thank you! And looks kosher from the review.

@yarikoptic yarikoptic merged commit 0d8693d into master May 30, 2023
@yarikoptic yarikoptic deleted the reporter branch May 30, 2023 18:23
@github-actions
Copy link

🚀 PR was released in v4.0.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup internal Changes only affect the internal API release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants