Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pending/deleted index/store behavior (renaming, recreating, etc.) #276

Closed
3 tasks done
brettz9 opened this issue Jan 20, 2017 · 1 comment
Closed
3 tasks done

pending/deleted index/store behavior (renaming, recreating, etc.) #276

brettz9 opened this issue Jan 20, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@brettz9
Copy link
Collaborator

brettz9 commented Jan 20, 2017

This was already mentioned in the Version 3.0.0 goals, but I wanted a separate issue for this. We need to take a particular look at:

  • pending/deleted index/store behavior (recreation, renaming)
  • index problems on w3c/IDBObjectStore.createIndex.js
  • ensuring deleted status across all IDBObjectStore handle instances
@brettz9 brettz9 added the Bug label Jan 20, 2017
@brettz9 brettz9 added this to the 3.0.0 milestone Jan 20, 2017
@brettz9 brettz9 self-assigned this Jan 20, 2017
brettz9 added a commit to brettz9/IndexedDBShim that referenced this issue Mar 30, 2017
…-create an object store that was deleted")

- Fix: Distinguish deleted and pending deleted stores and indexes;
    for insertion operations, do index checks independent of
    `indexNames` in case subsequently deleted by `deleteIndex` (indexeddbshim#276)
- Testing (Grunt): Make QUnit tasks more granular
- Testing (QUnit): Avoid origin-checking
brettz9 added a commit to brettz9/IndexedDBShim that referenced this issue Mar 31, 2017
    for insertion operations, do index checks independent of
    `indexNames` in case subsequently deleted by `deleteIndex` (indexeddbshim#276)
- Fix: Ensure same index instance object returned for same store object and
    index name
- Fix: Better error reporting for `IDBRequest.error` or `IDBRequest.result`
    errors.
- Testing (Grunt): Make QUnit tasks more granular
- Testing (QUnit): Avoid origin-checking
- Testing (W3C): Report on bad files not expected to be such (not in the list)
- Testing (Mocha): Add test for index instance clones

Current IndexedDB (and domstringlist) test statuses
  'Pass': 1102, (including 4 domstringlist tests but avoiding exclusions)
  'Fail': 69,
  'Timeout': 4,
  'Not Run': 2,
  'Total tests': 1177 (including 4 domstringlist tests but avoiding exclusions)

322 normal files (including 1 domstringlist file):
        288 are all good, 30 have at least some bad, 4 time out, 2 do not run
    7 excluded files (uncaught exceptions during testing)
@brettz9
Copy link
Collaborator Author

brettz9 commented Mar 31, 2017

Fixed in master.

@brettz9 brettz9 closed this as completed Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant