Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should document that .addn() is limited to < 0x4000000 #176

Open
axic opened this issue Feb 7, 2018 · 1 comment
Open

Should document that .addn() is limited to < 0x4000000 #176

axic opened this issue Feb 7, 2018 · 1 comment
Labels
question / documentation

Comments

@axic
Copy link
Contributor

axic commented Feb 7, 2018

And the preferred way for large numbers is .add(new BN(...))
@axic axic mentioned this issue Feb 7, 2018
Merged
@axic
Copy link
Contributor Author

axic commented Feb 7, 2018 •
edited
Loading

Or instead of the assertion, it could have a conditional if (num >= 0x4000000) return iadd(new BN(num))

@axic axic mentioned this issue Feb 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question / documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@axic @dcousens