feat(stdlib/contrib): add teams package #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please move this module to use our new "contrib" layout? You can see how to do that here. |
sranka
changed the title
sranka
force-pushed
the
feat/teams
branch
3 times, most recently
from
83b3fed to
0583b2a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2866 +/- ##
=======================================
Coverage 50.81% 50.81%
=======================================
Files 317 318 +1
Lines 40307 40309 +2
=======================================
+ Hits 20482 20484 +2
Misses 17454 17454
Partials 2371 2371
Continue to review full report at Codecov.
|
|
@rockstar it is now refactored to a new contrib layout + I also added a README.md to the new package. |
rockstar
approved these changes
Jun 10, 2020
sranka
force-pushed
the
feat/teams
branch
2 times, most recently
from
1b483e4 to
e3eb0f0
Compare
sranka
commented
Jun 11, 2020
libflux/src/core/semantic/types.rs
Outdated
| @@ -1144,7 +1144,7 @@ impl Function { | |||
| // This means they should match. Enforce this condition by inserting | |||
| // the pipe argument into the required ones with the same key. | |||
| f.req.insert(fp.k.clone(), fp.v); | |||
| g.req.insert(fp.k.clone(), gp.v); | |||
| g.req.insert(fp.k, gp.v); | |||
There was a problem hiding this comment.
discovered by clippy, required for the tests to pass
|
@rockstar conflicts resolved, a new rust's clippy recommendation applied, pls merge |
rockstar
approved these changes
Jun 18, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds teams package to flux so that notifications can be sent from flux to Microsoft Teams. It is the first step in influxdata/influxdb#17939
Notes:
Done checklist