-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alert handler for Microsoft Teams #1965
Conversation
Is there anyone who can take a look at this? @nathanielc? I'll be happy to update the docs once this is approved and merged. |
@nathanielc Is there a way that this can be merged into Kapacitor code base for usage? I know that we use this heavily internally and this feature would be a huge plus. |
@nathanielc |
@mmindenhall For example, with cards fields |
Is this planned to be merged soon? |
Wondering as well if this will be merged soon? |
@StefanSa, unfortunately there is no way to change the theme or text color within a card. I agree that this is a significant shortcoming compared to Slack. |
@mmindenhall think that is not 100% correct. or alerta to teams: |
Ah, yes, you are right @StefanSa. I never tried the According to the message card reference, the setting is intended for branding rather than communicating status:
It would be easy to add to the card...but all it does is change the color of a line across the top of the card (screenshot). |
@mmindenhall Playground on MS Alert
OK
|
@StefanSa, I think the best way to implement support for [teams]
theme-color-enabled = true # enabled by default
ok-color = "008000" # green
info-color = "008080" # teal
warning-color = "FFFF00" # yellow
critical-color = "FF0000" # red
max-level-color = "800000" # maroon When the theme color is enabled, the Teams handler will configure the card with the color matching the alert level. HOWEVER, it's been more than 10 months since I submitted this PR, and for some reason the team has ignored it completely. I don't plan to add to this PR unless/until it either gets merged, or the team lets me know what needs to be done for it to be merged. |
@mmindenhall yes, unfortunately it has become quiet around kapacitor. @nathanielc @rbetts |
@StefanSa It doesn't seem like it's that quiet, as many other pull requests have been accepted. Hard to think of a good reason why nice work like this that has no conflicts wouldn't be accepted. I can't think of a few really lame reasons (mostly having to do with bias towards certain vendors). |
So that there is no further speculation, it would be helpful if explained here why this good PR |
Please merge this. Microsoft Teams support is an important feature to those of us who use Microsoft Teams. |
Bump and +1 . Is there any word on what needs to happen to move this one along? Also, as an aside as to why this PR is important, Microsoft Teams is now bigger than Slack |
Please accept this. |
I'm investigating whether my company can use TICK. This feature is vital for us (thanks, mmindenhall for creating it!). Can we have an indication as to whether it's going to be merged? |
More than a year, and this is still open. Every check passed, except the merge button. This is an important feature, please just merge. |
I did a little script in the meantime. If it helps... Https://github.com/UpperM/kapacitor-msteams |
any news on this ? |
pls merge :( |
Hi. I am actually also very interested in this. Unfortunately, the company I work for loves M$ and their products, so, Teams it is. It would indeed be nice to get some feedback from @nathanielc or anyone else form @influxdata. I could also help hands-on if that is what it takes. Cheers, |
Any eta @nathanielc ? |
Hi everyone! We would really like to use Kapacitor at my current company as well, and since all our communications use Microsoft Teams, this is a real blocker for us. Thanks a lot! |
Hi, |
Hey @docmerlin I saw you've been going through other PRs, any plans to review this one? |
@mattnotmitt I do! I have to get a Microsoft Teams account first to test it though. |
Hi, I see that this is merged already. Is this feature available or waiting for next release? May I ask the eta for next release? |
Great to see this was merged. Like what @mertbakir mentioned, is there a preferred means to monitor for upcoming releases and features/fixes contained within? |
@southbay82 click the Watch button on the repository and choose "releases only". You'll get an email/github notification when a release gets pushed on the repo. CHANGELOG.md should contain any updates when the release is created. |
When are you planning to release this feature? |
The documentation is there but it do not seems to be released right? I tried it and i ended up with this error while declaring a topic-handler
Any update about this? @docmerlin |
OK this works now with Kapacitor 1.8.5 but it sends: It should be: Can we fix this? Should I open a new issue? |
I'm running Kapacitor 1.5.6-1 and Chronograf 1.8.5-1, and I've enabled Teams Event Handler as described here https://docs.influxdata.com/kapacitor/v1.5/event_handlers/microsoftteams/#set-up-teams Kapacitor service restarts fine (no apparent errors in log messages) after configuration changes, however I'm not seeing "Teams" in Chronograf under "Alert Handlers", which I am guessing it should. Am I missing anything? |
Did you addressed this as an issue? |
No, I didn't. |
Required for all non-trivial PRs
Required only if applicable
You can erase any checkboxes below this note if they are not applicable to your Pull Request.
N/A
This adds support for sending alerts via Microsoft Teams (similar to Slack or HipChat). I followed the alert handlers guide where possible, and when I ran into problems, I looked at the source code for other alerts (e.g., HipChat). The tests implemented follow the same pattern of tests performed by the HipChat handler.
All tests are passing for me locally (except some unrelated UDF tests which fail due to python issues on my Mac).