-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection Loss Improvement #1412
Conversation
…end of write cycle so we don't hold open idle connections, which has the benefit of mostly removing the chance of getting hopelessly connection lost
…into telegraf master
…ed ident & auth handshake
correct URL from instrumental fork to origin and put the change in the correct part of the file
Looks good to me. Probably what I would have eventually done. I've tried a number of different ways to try to catch disconnects but haven't gotten anything to work reliably. |
Yeah, we tried everything we could for a couple days, but it seems like the golang primitives are not built with dealing with disconnection in mind. We have some internal work on instrumental going that will allow for ack'ing, which will simplify disconnect detection and we can circle back round to this output. Thanks for looking! |
you need to run |
@Sparcc This has been |
thanks @janxious! |
What & Why
Required for all PRs:
@jasonroelofs pinging you since you wrote the first version