Moving cgroup path name to field from tag to reduce cardinality #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding assertContainsFields function to cgroup_test for custom validation
|
looks good, thanks @sebito91 |
ghost
mentioned this pull request
3 tasks
sparrc
pushed a commit
that referenced
this pull request
Oct 12, 2016
3 tasks
sparrc
pushed a commit
that referenced
this pull request
Oct 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised commit that moves the cgroup path name away from tags and into the fields. This information is quite useful to debug jobs, processes, other things that live under the cgroup headings in distinct folders. Having the value listed as a tag drastically increases cardinality so moving it to a field allows it to remain as a a value we can query.
Required for all PRs: