Ceph: represent pgmap states using tags #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-vizcaino
changed the title
|
please update the changelog and put a release note in the 1.3 section |
|
CHANGELOG updated. PR has been rebased to current master. |
mlindes
pushed a commit
to Comcast/telegraf
that referenced
this pull request
Feb 6, 2017
* ceph: maps are already refs, no need to use a pointer * ceph: pgmap_states are represented in a single metric "count", differenciated by tag * Update CHANGELOG
|
Beware that the "state" of a PG is essentially a bitmap of flags. Storing it as a primitive string e.g. "active+clean+scrubbing+deep" is going to increase series cardinality and not be particularly useful to query by. |
|
@dswarbrick Maybe splitting states using the '+' separator would be a better option then? That would narrow the cardinality of states. The only strange result would be that the sum of all the pg_states metrics would be greater or equal than the total number PG in the cluster (because a PG can have multiple states at once, eg. active & clean). |
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
* ceph: maps are already refs, no need to use a pointer * ceph: pgmap_states are represented in a single metric "count", differenciated by tag * Update CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Description
This PR changes the layout of fields used for the
ceph_pgmap_statemetric according to what was proposed in issue #2224Test for the corresponding code has been added and the code for
decodeStatusPgmapState()simplified.