-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeout option to IPMI sensor input plugin #2818
Conversation
0f89a81
to
8711d3c
Compare
Looks good, can you add it to the CHANGELOG? |
@danielnelson, I've updated the CHANGELOG as requested. |
Can you change the default to 5s as well? Since the default interval is 10s we should keep it under that. |
The problem with 5s is that is just too low and users would have to often override that. If you are okay with it, I will change it back to 5s. |
closes #1565 |
How much time do we need to query a single localhost server? If we only need >5s for mutliple remote servers than I am comfortable requiring the user to increase the timeout. |
So, via the IPMI kernel interface (which is local), it takes more than 5 seconds on some of my boxes. # time ipmitool sdr >/dev/null
real 0m8.026s
user 0m0.000s
sys 0m0.003s I'd imagine over the network should be more expensive. |
So maybe we should set the timeout = 20s and also add interval = 30s, similar to what we did for the cloudwatch input. |
@danielnelson - I've made the changes as requested. Let me know if there's anything that needs fixing. |
Solves #2817.
Required for all PRs: