Add http path configuration for OpenTSDB plugin #4347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glinton
reviewed
Jun 28, 2018
| @@ -123,7 +124,7 @@ func (o *openTSDBHttp) flush() error { | |||
| Scheme: o.Scheme, | |||
| User: o.User, | |||
| Host: fmt.Sprintf("%s:%d", o.Host, o.Port), | |||
| Path: "/api/put", | |||
| Path: o.Path, | |||
There was a problem hiding this comment.
Can you default o.Path to "/api/put" in order to not break any current implementations.
There was a problem hiding this comment.
👍 This should be all set now
glinton
approved these changes
Jul 2, 2018
danielnelson
added
the
feat
|
After merging I switched the config to use snake_case format, either format will work for now since there is no field tags but this is the preferred style. 2ee374c |
rgitzel
pushed a commit
to rgitzel/telegraf
that referenced
this pull request
Oct 17, 2018
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the OpenTSDB to allow for the path to be configured when using the HTTP client. Currently there is no way for telegraf to send data to OpenTSDB servers behind a reverse proxy with non default routes.
Required for all PRs: