Fix segfault in x509_cert #4874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When no tls params are in config, tlsCfg will be nil - fix setting hostname in tlsCfg it will contain the port number and never correctly match server certs - Add a test that shows that it now works - Fix readme as port number is required in soruces
danielnelson
approved these changes
Oct 17, 2018
glinton
pushed a commit
that referenced
this pull request
Oct 17, 2018
(cherry picked from commit 48745c3)
|
@glinton , when can I expected a Docker image with this fix (telegraf:1.8.2-alpine)? The milestone was closed 7 days ago, but I'm unable to use it. |
|
Oops, it seems circle ci was having trouble hitting mit's gpg servers and the tests failed, I've restarted them and will keep a close eye on it today and make sure it gets done today. Thanks for the heads up/reminder. |
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its currently possible to workaround the crash by adding
insecure_skip_verify = trueto the confRequired for all PRs: