-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added plugin to read Windows performance counters #575
Added plugin to read Windows performance counters #575
Conversation
"fmt" | ||
"strings" | ||
"syscall" | ||
//"time" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented import
Thanks a bunch @TheFlyingCorpse, this is great for windows support 👍! A few things to address:
|
cf3a7d1
to
36e74db
Compare
I'm still working on the unit tests, will try to have something tomorrow! |
@TheFlyingCorpse Is this ready to merge? |
@sparrc - Yes, I have formatted the code to the best of my ability and added unit tests for both the configuration parsing and doing test queries on Windows. |
@TheFlyingCorpse can you please squash your commits and rebase off master? |
cab3691
to
6bad082
Compare
6bad082
to
15ec51a
Compare
@sparrc, done! |
thanks @TheFlyingCorpse! this is in master now |
note: I changed the name to |
Plugin that reads performance counters from Windows, a lot of examples included to get an idea how to use this with IIS and AD to start with.
The plugin is flexible so you can have a master configuration to push out to all, it will only submit from each host what is matching to your configuration.