Statsd datadog #5791
Merged
Statsd datadog #5791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glinton
added
feat
goller
suggested changes
May 7, 2019
goller
reviewed
May 7, 2019
glinton
suggested changes
May 7, 2019
danielnelson
suggested changes
May 7, 2019
plugins/inputs/statsd/datadog.go
Outdated
| if rawMetadataFields[i][0] == '#' { | ||
| parseDataDogTags(m.tags, rawMetadataFields[i][1:]) | ||
| } else { | ||
| log.Printf("W! [inputs.statsd] unknown metadata type: '%s'", rawMetadataFields[i]) |
There was a problem hiding this comment.
I think if the message is malformed an error should be returned up from here and then logged. Doing a best effort parse doesn't make sense unless we find that the datadog agent regularly emits bad messages.
plugins/inputs/statsd/datadog.go
Outdated
| if message[i] == ',' { | ||
| if k == "" { | ||
| k = message[start:i] | ||
| tags[k] = "" |
There was a problem hiding this comment.
I don't think it is allowed to have an empty tag value in InfluxDB, we just toss them at serialize time.
goller
reviewed
May 9, 2019
goller
suggested changes
May 9, 2019
goller
approved these changes
May 9, 2019
danielnelson
suggested changes
May 9, 2019
glinton
approved these changes
May 10, 2019
danielnelson
suggested changes
May 10, 2019
danielnelson
approved these changes
May 14, 2019
hwaastad
pushed a commit
to hwaastad/telegraf
that referenced
this pull request
Jun 13, 2019
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5224
This adds Datadog events to the Statsd input plugin.