Introduce forceKill logic #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO - add a section in the readme with an example and description of the behavior |
mphillips-infoblox
previously approved these changes
Apr 5, 2021
mphillips-infoblox
approved these changes
Apr 5, 2021
| defer c.mu.Unlock() | ||
| err := c.conn.Close() | ||
|
|
||
| if err == nil { |
There was a problem hiding this comment.
There can be valid reasons an error is returned. For example, if the underlying driver already closed the connection. I think here we just log the error (if any) and mark as "killed" no matter what.
| defer cg.mu.Unlock() | ||
|
|
||
| if v, ok := vs[forceKill]; ok { | ||
| firstValue := v[0] |
There was a problem hiding this comment.
This code works fine for the positive case. If someone mistypes the camelCase, they don't get confirmation that their "settings" were bad, however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.