Implement SessionResetter interface #7
Conversation
Yeah, but why? Do you think the filesystem will need to be checked more often than two seconds? Not sure if this is a good thing to open up to users who are likely to misinterpret its usage. |
|
That is true, but we may want to make it longer depending on how the secret updating strategy is configured. |
|
|
ok, lets leave it for now |
| @@ -95,6 +96,14 @@ func (c *managedConn) IsValid() bool { | |||
| return s.IsValid() | |||
| } | |||
|
|
|||
| func (c *managedConn) ResetSession(ctx context.Context) error { | |||
| if c.reset { | |||
There was a problem hiding this comment.
This variable is inspected but it is set when a mutex is set; this is a race condition.
This interface allows the driver to tell database/sql when a connection needs to be discarded from the pool.
These methods in this hierarchy end up calling db.conn which requests a connection from the pool and asks the driver if a reset is needed. thus flushing the connection pool.